Fix remote constants. #7689
Merged
Fix remote constants. #7689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do not know how to create a good simple test. |
|
Is this related to #7247 , e.g. should we prevent pushing down non-deterministic functions to remote server? |
|
@akuzm I think it is strange to use functions like |
|
uptime is already marked as non-deterministic, while version is deterministic. Maybe we should mark it as deterministic in scope of query, and only ship deterministic functions to replicas. |
|
Yes, it seems reasonable. |
KochetovNicolai
force-pushed
the
constants-and-remote
branch
from
4b6e8bb
to
0ba523a
Compare
KochetovNicolai
added
the
pr-bugfix
KochetovNicolai
added a commit
that referenced
this pull request
Nov 9, 2019
Fix remote constants. (cherry picked from commit 2233660)
KochetovNicolai
added a commit
that referenced
this pull request
Nov 9, 2019
Fix remote constants. (cherry picked from commit 2233660)
KochetovNicolai
added a commit
that referenced
this pull request
Nov 9, 2019
Fix remote constants. (cherry picked from commit 2233660)
KochetovNicolai
added a commit
that referenced
this pull request
Nov 9, 2019
Fix remote constants. (cherry picked from commit 2233660)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (up to few sentences, not needed for non-significant PRs):
Fix possible incorrect result for constant functions from remote servers. It happened for queries with functions like
version(),uptime(), etc. which returns different constant values for different servers. #7666Detailed description (optional):
Get constant values from remote source in RemoteBlockInputStream.